Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dev Loading controller without activity for VR #35392

Closed

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
Changelog:
[General][Added] - For supporting Dev Loading View across platforms, adding the DevLoadingViewController without an activity/context.

Differential Revision: D40947239

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 18, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40947239

@analysis-bot
Copy link

analysis-bot commented Nov 18, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,102,558 +118
android hermes armeabi-v7a 6,470,621 +128
android hermes x86 7,520,011 +116
android hermes x86_64 7,378,685 +112
android jsc arm64-v8a 8,967,210 -99
android jsc armeabi-v7a 7,698,059 -93
android jsc x86 9,029,323 -95
android jsc x86_64 9,507,162 -101

Base commit: 850f855
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 18, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d9ade19
Branch: main

@pull-bot
Copy link

PR build artifact for a74781a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for a74781a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary:
Pull Request resolved: facebook#35392

Changelog:
    [General][Added] - For supporting Dev Loading View across platforms, adding the DevLoadingViewController without an activity/context.

Reviewed By: rshest

Differential Revision: D40947239

fbshipit-source-id: fcc524b33d9df174cd0d11ae6c1a00a04f3042bc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40947239

@pull-bot
Copy link

PR build artifact for 020ec7b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 020ec7b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#35392

Changelog:
    [General][Added] - For supporting Dev Loading View across platforms, adding the DevLoadingViewController without an activity/context.

Reviewed By: rshest

Differential Revision: D40947239

fbshipit-source-id: de124b0a7ee39dc7da3c1c45972a6703eff2f0ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants